Using the full launch speed as the horizontal component
Only v cos θ is horizontal and only v sin θ is vertical.
Assuming the horizontal velocity changes during the flight
With air resistance ignored, vx stays constant.
Using the total speed to find the time of flight
The time comes from the vertical motion alone.
Setting the vertical velocity to zero at the landing point
The vertical velocity is zero only at the highest point; at landing it is nonzero and, for equal launch and landing heights, has the same size as the launch vertical velocity.
Adding relative speeds as plain numbers when the motions are perpendicular
Components or Pythagoras’ theorem must be used.
Forgetting that a projectile launched horizontally from a height has an initial vertical velocity of zero
So the time of fall depends only on the height.